Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 910923002: Make yield* throw an error if not yielding an Iterable (Closed)

Created:
5 years, 10 months ago by hausner
Modified:
5 years, 10 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org, sigurdm, floitsch
Visibility:
Public.

Description

Make yield* throw an error if not yielding an Iterable Fixes issue 22323 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=43616

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M runtime/lib/core_patch.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/sync_generator1_test.dart View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 10 months ago (2015-02-09 21:17:41 UTC) #2
gbracha
test lgtm
5 years, 10 months ago (2015-02-09 21:25:39 UTC) #3
gbracha
lgtm
5 years, 10 months ago (2015-02-09 21:26:54 UTC) #4
hausner
5 years, 10 months ago (2015-02-09 21:47:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698