Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 910863003: Implement windows support for having multiple Dart_Port's registered on one OS socket (Closed)

Created:
5 years, 10 months ago by kustermann
Modified:
5 years, 10 months ago
Reviewers:
wibling, Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement windows support for having multiple Dart_Port's registered on one OS socket R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=43631

Patch Set 1 #

Patch Set 2 : Disable token counting on windows #

Total comments: 2

Patch Set 3 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -158 lines) Patch
M dart/runtime/bin/eventhandler.h View 1 14 chunks +63 lines, -19 lines 0 comments Download
M dart/runtime/bin/eventhandler_android.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M dart/runtime/bin/eventhandler_linux.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M dart/runtime/bin/eventhandler_win.h View 1 2 12 chunks +36 lines, -46 lines 0 comments Download
M dart/runtime/bin/eventhandler_win.cc View 1 21 chunks +89 lines, -89 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kustermann
There are timeouts and I haven't been able to figure out the reason for them ...
5 years, 10 months ago (2015-02-09 17:09:14 UTC) #2
kustermann
Disabling the token mechanism (as it was before) makes all tests pass -- we might ...
5 years, 10 months ago (2015-02-10 08:59:21 UTC) #3
Søren Gjesse
lgtm https://codereview.chromium.org/910863003/diff/20001/dart/runtime/bin/eventhandler_win.h File dart/runtime/bin/eventhandler_win.h (right): https://codereview.chromium.org/910863003/diff/20001/dart/runtime/bin/eventhandler_win.h#newcode421 dart/runtime/bin/eventhandler_win.h:421: explicit ClientSocket(intptr_t s) : DescriptorInfoSingleMixin(s, true), Indentation.
5 years, 10 months ago (2015-02-10 09:10:20 UTC) #4
kustermann
https://codereview.chromium.org/910863003/diff/20001/dart/runtime/bin/eventhandler_win.h File dart/runtime/bin/eventhandler_win.h (right): https://codereview.chromium.org/910863003/diff/20001/dart/runtime/bin/eventhandler_win.h#newcode421 dart/runtime/bin/eventhandler_win.h:421: explicit ClientSocket(intptr_t s) : DescriptorInfoSingleMixin(s, true), On 2015/02/10 09:10:19, ...
5 years, 10 months ago (2015-02-10 10:08:51 UTC) #5
kustermann
5 years, 10 months ago (2015-02-10 10:09:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43631 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698