Issue 91043003: Simplify some argument checking for socket calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 91043003: Simplify some argument checking for socket calls (Closed)

Created:
7 years ago by Søren Gjesse

Modified:
7 years ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify some argument checking for socket calls Ensure valid range in the C++ code. Leave any argument checking with "user-friendly" error messaged to the Dart code. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30713

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added one more check #

Patch Set 3 : Addressed review comments #

Patch Set 4 : Addressed review comments #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -40 lines)			Patch
M	runtime/bin/dartutils.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 2	1 chunk	+11 lines, -1 line	0 comments	Download
M	runtime/bin/socket.cc	View	1 2	3 chunks	+32 lines, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/91043003/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/91043003/diff/1/runtime/bin/socket.cc#newcode106 runtime/bin/socket.cc:106: int64_t port = DartUtils::GetIntegerValueCheckRange( Call it GetInt64ValueCheckRange?

7 years ago (2013-11-27 12:06:48 UTC) #2

Søren Gjesse

https://codereview.chromium.org/91043003/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/91043003/diff/1/runtime/bin/socket.cc#newcode106 runtime/bin/socket.cc:106: int64_t port = DartUtils::GetIntegerValueCheckRange( On 2013/11/27 12:06:48, Anders Johnsen ...

7 years ago (2013-11-27 12:11:54 UTC) #3

Søren Gjesse

7 years ago (2013-11-27 12:12:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r30713 (presubmit successful).

Expand Messages | Collapse Messages