Issue 910313002: Rename IsConstructor to IsGenerativeConstructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 910313002: Rename IsConstructor to IsGenerativeConstructor. (Closed)

Created:
5 years, 10 months ago by rmacnak

Modified:
5 years, 10 months ago

Reviewers:
Cutch, WRONG ACCOUNT, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Rename IsConstructor to IsGenerativeConstructor. This matches the terminology in the spec, and it avoids confusion with the function kind kConstructor, which indicates either a generative constructor or a factory constructor. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43673

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -39 lines)			Patch
M	runtime/lib/mirrors.cc	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	9 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/native_arguments.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/parser.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

5 years, 10 months ago (2015-02-11 00:59:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43673 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages