Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 910243002: Re-apply "Fix warning in sync_generator1_test.dart" (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
ricow1, hausner
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-apply "Fix warning in sync_generator1_test.dart" This re-applies commit 43626, which was reverted in 43628. What happened: I accidentally tested r43626 against a work-in-progress build of the Java-based dartanalyzer that contained r43655, so I failed to update the status files properly. This resulted in a build failure, which was addressed by reverting r43626. Now that r43655 has landed, the build failure should not occur. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=43666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tests/language/language_analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/sync_generator1_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-10 18:11:27 UTC) #2
hausner
lgtm
5 years, 10 months ago (2015-02-10 19:36:44 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-10 20:32:51 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698