Reafctor to use 'const RawAddr&' or 'RawAddr*' in the eventhandler code

Reafctor to use 'const RawAddr&' or 'RawAddr*' in the eventhandler code

Also pass the port as part of RawAddr instead of in a separate argument
when both addr and port are passed.

R=kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43722

[Søren Gjesse, 2015-02-11 14:19:55]

I have not compiled the code on OS X or Windows yet.

[kustermann, 2015-02-11 14:54:31]

Combinding the port with addr might make it more error-prone -- just forgetting
the `SocketAddress::SetAddrPort(&addr, port);` at one place is enough.

https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h
File runtime/bin/socket.h (right):

https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h#newcode148
runtime/bin/socket.h:148: RawAddr* ptr = &const_cast<RawAddr&>(raw);
Could you explain why it is necessary to remove the const here? This function
should only access `raw` in a read-only way, right?

https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h#newcode320
runtime/bin/socket.h:320: static intptr_t CreateBindListen(const RawAddr& addr,
Please add a comment here (and other places) where we assume that a valid port
is set in addr with `SocketAddress::SetAddrPort(&addr, port);`.

[Søren Gjesse, 2015-02-11 15:19:33]

On 2015/02/11 14:54:31, kustermann wrote:
> Combinding the port with addr might make it more error-prone -- just
forgetting
> the `SocketAddress::SetAddrPort(&addr, port);` at one place is enough.

When there is no port argument this this should be fine. We where already doing
this for the SendTo where the destination was specified as just a RawAddr.

> 
> https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h
> File runtime/bin/socket.h (right):
> 
>
https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h#newcode148
> runtime/bin/socket.h:148: RawAddr* ptr = &const_cast<RawAddr&>(raw);
> Could you explain why it is necessary to remove the const here? This function
> should only access `raw` in a read-only way, right?
> 
>
https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h#newcode320
> runtime/bin/socket.h:320: static intptr_t CreateBindListen(const RawAddr&
addr,
> Please add a comment here (and other places) where we assume that a valid port
> is set in addr with `SocketAddress::SetAddrPort(&addr, port);`.

[Søren Gjesse, 2015-02-11 15:19:39]

https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h
File runtime/bin/socket.h (right):

https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h#newcode148
runtime/bin/socket.h:148: RawAddr* ptr = &const_cast<RawAddr&>(raw);
On 2015/02/11 14:54:31, kustermann wrote:
> Could you explain why it is necessary to remove the const here? This function
> should only access `raw` in a read-only way, right? 

Taking the address below is not allowed whithout casting away const.

https://codereview.chromium.org/910183003/diff/1/runtime/bin/socket.h#newcode320
runtime/bin/socket.h:320: static intptr_t CreateBindListen(const RawAddr& addr,
On 2015/02/11 14:54:31, kustermann wrote:
> Please add a comment here (and other places) where we assume that a valid port
> is set in addr with `SocketAddress::SetAddrPort(&addr, port);`.

Done.

[kustermann, 2015-02-11 15:47:48]

lgtm

[Søren Gjesse, 2015-02-12 10:10:50]

New patchsets have been uploaded after l-g-t-m from kustermann@google.com

[Søren Gjesse, 2015-02-12 11:39:33]

Committed patchset #4 (id:60001) manually as 43722.

[Bill Hesse, 2015-02-12 12:28:00]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2015-02-12 12:28:00]

https://codereview.chromium.org/910183003/diff/60001/runtime/bin/socket_linux.cc
File runtime/bin/socket_linux.cc (right):

https://codereview.chromium.org/910183003/diff/60001/runtime/bin/socket_linux...
runtime/bin/socket_linux.cc:552: int proto = addr.addr.sa_family == AF_INET ?
IPPROTO_IP : IPPROTO_IPV6;
These changes need to be made to JoinMulticast and LeaveMulticast in the
socket_android.cc file as well.