Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 909743002: Version bump pre dev pub push. (Closed)

Created:
5 years, 10 months ago by pquitslund
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
5 years, 10 months ago (2015-02-09 00:11:52 UTC) #2
scheglov
LGTM for -dev.1 variant. https://codereview.chromium.org/909743002/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/909743002/diff/1/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.24.0-dev.0 I have never ...
5 years, 10 months ago (2015-02-09 00:16:03 UTC) #3
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-09 00:36:14 UTC) #4
pquitslund
Thanks! https://codereview.chromium.org/909743002/diff/1/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/909743002/diff/1/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.24.0-dev.0 On 2015/02/09 00:16:03, scheglov wrote: > ...
5 years, 10 months ago (2015-02-09 03:56:33 UTC) #5
pquitslund
5 years, 10 months ago (2015-02-09 05:13:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698