Issue 909493004: Stop re-analyzing everything when adding a file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 909493004: Stop re-analyzing everything when adding a file (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson

Modified:
5 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Stop re-analyzing everything when adding a file R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43734

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -98 lines)			Patch
	M	pkg/analyzer/lib/src/generated/engine.dart	View		9 chunks	+78 lines, -98 lines	2 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/909493004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/909493004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode4961 pkg/analyzer/lib/src/generated/engine.dart:4961: * Create an entry for the newly added ...

5 years, 10 months ago (2015-02-12 16:54:50 UTC) #3

Brian Wilkerson

Committed patchset #1 (id:1) manually as 43734 (presubmit successful).

5 years, 10 months ago (2015-02-12 19:03:08 UTC) #4

Brian Wilkerson

5 years, 10 months ago (2015-02-12 19:03:37 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/909493004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/909493004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:4961: * Create an entry for the newly
added source. Return `true` if the new source is a Dart
Done

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages