Issue 909373003: Report an error on Dart Source reading exception.

Issue 909373003: Report an error on Dart Source reading exception. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Report an error on Dart Source reading exception. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43694

Patch Set 1 #

Total comments: 3

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -4 lines)			Patch
M	pkg/analyzer/lib/src/generated/engine.dart	View	1 chunk	+10 lines, -0 lines	3 comments	Download
M	pkg/analyzer/lib/src/generated/scanner.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	7 chunks	+32 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

https://codereview.chromium.org/909373003/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/909373003/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode4693 pkg/analyzer/lib/src/generated/engine.dart:4693: new AnalysisError.con1(source, ScannerErrorCode.UNABLE_GET_CONTENT)]); Would it be better to create ...

5 years, 10 months ago (2015-02-10 23:26:14 UTC) #2

Brian Wilkerson

LGTM https://codereview.chromium.org/909373003/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/909373003/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode4689 pkg/analyzer/lib/src/generated/engine.dart:4689: if (sourceEntry is DartEntry) { We probably shouldn't ...

5 years, 10 months ago (2015-02-11 00:49:10 UTC) #3

scheglov

5 years, 10 months ago (2015-02-11 18:22:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43694 (presubmit successful).

Expand Messages | Collapse Messages