Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 909323002: pkg/unittest: More explicit skipping of src file that looks like test (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More explicit skipping of src file that looks like test R=nweiz@google.com Committed: https://github.com/dart-lang/unittest/commit/2b2237cc34f95e04de4fa6092fafaa656dbba51a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M .status View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 10 months ago (2015-02-10 21:58:08 UTC) #2
nweiz
Sorry, I should have caught this. * doesn't match across directories in status files.
5 years, 10 months ago (2015-02-10 22:06:44 UTC) #3
nweiz
lgtm
5 years, 10 months ago (2015-02-10 22:06:56 UTC) #4
kevmoo
5 years, 10 months ago (2015-02-10 22:30:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b2237cc34f95e04de4fa6092fafaa656dbba51a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698