Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 909253002: Fix a windows build issue (Closed)

Created:
5 years, 10 months ago by siva
Modified:
5 years, 10 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix a windows build issue ../../dart/runtime/vm/flags.cc:58:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] OS::Print("%s: %"Pu64" (%s)\n", name_, *this->uint64_ptr_, comment_); R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=43669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M runtime/vm/disassembler_arm64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flags.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 10 months ago (2015-02-10 21:00:58 UTC) #2
regis
LGTM Thanks for fixing.
5 years, 10 months ago (2015-02-10 21:16:19 UTC) #3
siva
5 years, 10 months ago (2015-02-10 21:30:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698