Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 908503004: Quick Assist to add explicit types to formal parameters. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Quick Assist to add explicit types to formal parameters. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43566

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak and add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 2 chunks +39 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years, 10 months ago (2015-02-06 19:46:26 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/908503004/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart File pkg/analysis_server/lib/src/services/correction/assist_internal.dart (right): https://codereview.chromium.org/908503004/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode332 pkg/analysis_server/lib/src/services/correction/assist_internal.dart:332: // prepare propageted type "propageted" --> "propagated" https://codereview.chromium.org/908503004/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode341 ...
5 years, 10 months ago (2015-02-06 19:57:08 UTC) #2
scheglov
5 years, 10 months ago (2015-02-06 20:03:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698