Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 908433002: - Make sure to fail early if an non-stacktrace is passed into the VM (Closed)

Created:
5 years, 10 months ago by Ivan Posva
Modified:
5 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Make sure to fail early if an non-stacktrace is passed into the VM where we expect one. Committed: https://code.google.com/p/dart/source/detail?r=43546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/exceptions.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Ivan Posva
TBR
5 years, 10 months ago (2015-02-06 09:23:07 UTC) #2
Ivan Posva
Committed patchset #1 (id:1) manually as r43546 (presubmit successful).
5 years, 10 months ago (2015-02-06 09:24:11 UTC) #3
hausner
5 years, 10 months ago (2015-02-06 16:58:10 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698