Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 907483004: Handle exception and clean-up code (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
This is in response to the stack trace Phil reported. The fix is in 'engine.dart'; ...
5 years, 10 months ago (2015-02-06 19:17:30 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-06 19:18:58 UTC) #3
Brian Wilkerson
5 years, 10 months ago (2015-02-06 19:20:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43563 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698