Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 906713002: Extract invoke-main stub generator. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase and remove whitespace. #

Total comments: 1

Patch Set 3 : Reupload after revert and rebase. #

Patch Set 4 : Fix by adding a missing semicolon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -73 lines) Patch
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 1 1 chunk +82 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 4 chunks +4 lines, -67 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
floitsch
https://codereview.chromium.org/906713002/diff/20001/pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart File pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart (right): https://codereview.chromium.org/906713002/diff/20001/pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart#newcode49 pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart:49: return js.statement(''' Copied over from other file. (Start reviewing ...
5 years, 10 months ago (2015-02-09 16:14:23 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-02-10 08:51:46 UTC) #3
floitsch
Committed patchset #2 (id:20001) manually as 43644 (presubmit successful).
5 years, 10 months ago (2015-02-10 13:39:39 UTC) #4
floitsch
Added a fix: the old emitter was now missing a ";" in minified mode (see ...
5 years, 10 months ago (2015-02-10 15:22:29 UTC) #6
floitsch
5 years, 10 months ago (2015-02-10 15:23:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 43653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698