Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 905823002: Verify proper API use of acquire/release typed data (Closed)

Created:
5 years, 10 months ago by koda
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

In this first version, we just track the set of objects and verify that calls to release match. The next step is to copy the data to a side buffer, which is then unmapped on release to catch use-after-release bugs. Explicitly disallow nested acquires, since the visibility of writes would depend on whether data is acquired in-place. Also explicitly disallow other access to the data (e.g., trough list accessors) for the same reason. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43575

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M runtime/include/dart_api.h View 1 chunk +9 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 chunks +27 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_state.h View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 10 months ago (2015-02-06 20:44:07 UTC) #2
siva
LGTM. I was wondering if we should also safe guard against shutting down an Isolate ...
5 years, 10 months ago (2015-02-06 21:13:00 UTC) #3
koda
5 years, 10 months ago (2015-02-06 22:31:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as r43575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698