Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 905653004: Clarify result returned by remainder intrinsics. (Closed)

Created:
5 years, 10 months ago by regis
Modified:
5 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Clarify result returned by remainder intrinsics. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43576

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M runtime/vm/intrinsifier_arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +3 lines, -1 line 2 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
Comments only. It took me a while to understand why the result was sometimes tagged, ...
5 years, 10 months ago (2015-02-06 22:22:44 UTC) #2
zra
lgtm https://codereview.chromium.org/905653004/diff/1/runtime/vm/intrinsifier_mips.cc File runtime/vm/intrinsifier_mips.cc (right): https://codereview.chromium.org/905653004/diff/1/runtime/vm/intrinsifier_mips.cc#newcode369 runtime/vm/intrinsifier_mips.cc:369: // V0: Tagged return result (remainder). V1 is ...
5 years, 10 months ago (2015-02-06 22:27:34 UTC) #3
regis
Thanks! https://codereview.chromium.org/905653004/diff/1/runtime/vm/intrinsifier_mips.cc File runtime/vm/intrinsifier_mips.cc (right): https://codereview.chromium.org/905653004/diff/1/runtime/vm/intrinsifier_mips.cc#newcode369 runtime/vm/intrinsifier_mips.cc:369: // V0: Tagged return result (remainder). On 2015/02/06 ...
5 years, 10 months ago (2015-02-06 22:42:41 UTC) #4
regis
5 years, 10 months ago (2015-02-06 22:42:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698