Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 904743003: Fix analyzer type checking of "await" expressions. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix analyzer type checking of "await" expressions. This requires implementing the "flatten()" rule defined in the spec; this rule also needs to be applied to static type checking of return types in async functions. BUG=dartbug.com/22291, dartbug.com/22293 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 2 chunks +41 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +39 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-05 23:30:00 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-06 00:24:46 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-06 03:33:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698