Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 904663005: Revert "Annotate dart:html constructor expressions with precise non-nullable types." (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Annotate dart:html constructor expressions with precise non-nullable types." Need to fix some html/element_types_test cases. TBR=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=43579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -269 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 56 chunks +61 lines, -61 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 63 chunks +63 lines, -63 lines 0 comments Download
M tests/html/element_types_test.dart View 2 chunks +9 lines, -118 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +11 lines, -17 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
5 years, 10 months ago (2015-02-07 00:34:31 UTC) #2
sra1
Committed patchset #1 (id:1) manually as 43579 (presubmit successful).
5 years, 10 months ago (2015-02-07 00:35:43 UTC) #3
Alan Knight
5 years, 10 months ago (2015-02-07 00:37:15 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698