Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 904653004: fix code completion in conditional expressions (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix code completion in conditional expressions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43538

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -27 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 3 chunks +153 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +38 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years, 10 months ago (2015-02-06 00:24:19 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-06 04:20:57 UTC) #3
danrubel
5 years, 10 months ago (2015-02-06 04:33:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698