Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 904603003: Fixed Window's Debug warning, results in compilation failure. (Closed)

Created:
5 years, 10 months ago by terry
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed Window's Debug warning, results in compilation failure. Reviewers=asiva@google.com R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terry
5 years, 10 months ago (2015-02-05 19:19:02 UTC) #2
terry
On 2015/02/05 19:19:02, terry wrote: Should have mentioned that the warnings are truncation of constant ...
5 years, 10 months ago (2015-02-05 19:25:47 UTC) #3
siva
lgtm
5 years, 10 months ago (2015-02-05 19:28:33 UTC) #4
terry
5 years, 10 months ago (2015-02-05 19:30:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43517 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698