Add test annotations to package:expect

Add test annotations to package:expect

BUG=
R=floitsch@google.com, herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43510

[Johnni Winther, 2015-02-05 14:42:54]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com, herhut@google.com

[herhut, 2015-02-05 15:59:16]

LGTM

I will add the support for the two type based annotations to the type inferrer.

[floitsch, 2015-02-05 16:17:27]

LGTM!

[Johnni Winther, 2015-02-05 16:30:11]

Committed patchset #2 (id:20001) manually as 43510 (presubmit successful).

[sra1, 2015-02-13 20:37:38]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-02-13 20:37:38]

https://codereview.chromium.org/903753002/diff/20001/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/903753002/diff/20001/pkg/expect/lib/expect.da...
pkg/expect/lib/expect.dart:400: /// Annotation class for testing of dart2js. Use
this as metadata on method
This is a strange place for these annotations.
Every test in the world can see them but they are specific to dart2js.

I would be much happier if these were in a separate library and shared with
sdk/lib/_internal/compiler/js_lib/annotations.dart

[floitsch, 2015-02-13 20:58:45]

https://codereview.chromium.org/903753002/diff/20001/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/903753002/diff/20001/pkg/expect/lib/expect.da...
pkg/expect/lib/expect.dart:400: /// Annotation class for testing of dart2js. Use
this as metadata on method
On 2015/02/13 20:37:38, sra1 wrote:
> This is a strange place for these annotations.
> Every test in the world can see them but they are specific to dart2js.
> 
> I would be much happier if these were in a separate library and shared with
> sdk/lib/_internal/compiler/js_lib/annotations.dart

:(
Didn't know/forgot about js_lib/annotations.dart.

We should merge them.

[floitsch, 2015-02-13 21:19:55]

https://codereview.chromium.org/903753002/diff/20001/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/903753002/diff/20001/pkg/expect/lib/expect.da...
pkg/expect/lib/expect.dart:400: /// Annotation class for testing of dart2js. Use
this as metadata on method
On 2015/02/13 20:58:45, floitsch wrote:
> On 2015/02/13 20:37:38, sra1 wrote:
> > This is a strange place for these annotations.
> > Every test in the world can see them but they are specific to dart2js.
> > 
> > I would be much happier if these were in a separate library and shared with
> > sdk/lib/_internal/compiler/js_lib/annotations.dart
> 
> :(
> Didn't know/forgot about js_lib/annotations.dart.
> 
> We should merge them.

Thinking more about it:
What would be the advantage of a separate library? The test still needs to run
in the VM. Importing dart2js-specific libraries into the test thus doesn't work.
In fact, given this constraint, we need to have the declarations visible to
every test. This makes a sharing pretty much impossible (or so complicated that
it isn't worth it).

However, we should align the naming of these two libraries.