Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 903283002: dart2js: fix deferred loading in the new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: fix deferred loading in the new emitter. Only works in drt/browser for now. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43654

Patch Set 1 #

Patch Set 2 : Rebase and clean up. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -52 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 12 chunks +97 lines, -50 lines 2 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
5 years, 10 months ago (2015-02-10 14:40:20 UTC) #2
zarah
LGTM https://codereview.chromium.org/903283002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/903283002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode980 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:980: // print('Setup: ' + (end - start) + ...
5 years, 10 months ago (2015-02-10 15:05:24 UTC) #3
floitsch
https://codereview.chromium.org/903283002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right): https://codereview.chromium.org/903283002/diff/20001/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart#newcode980 pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:980: // print('Setup: ' + (end - start) + ' ...
5 years, 10 months ago (2015-02-10 15:13:35 UTC) #4
floitsch
The following test is not yet running, but I will still commit and fix it ...
5 years, 10 months ago (2015-02-10 15:33:12 UTC) #5
floitsch
5 years, 10 months ago (2015-02-10 15:33:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43654 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698