Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issue 902913002: fix completions in indexed expression (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix completions in indexed expression BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -32 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 3 chunks +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 4 chunks +54 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 3 chunks +36 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 10 months ago (2015-02-05 21:37:20 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-05 21:40:20 UTC) #3
danrubel
5 years, 10 months ago (2015-02-05 21:42:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698