The execution of an async* should only be scheduled when the stream is

Only schedule the execution of an async* when the stream is
subscribed to.


BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43646

[sigurdm, 2015-02-10 12:54:45]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-02-10 12:54:56]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-10 13:27:50]

LGTM except for the part in the `onPause` callback.

I would prefer to reduce the number helper functions, but we can look at that
later.

https://codereview.chromium.org/902783008/diff/20001/pkg/compiler/lib/src/js/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/902783008/diff/20001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:191: /// Sepcific to async* methods.
Specific

https://codereview.chromium.org/902783008/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/902783008/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3553: streamHelper(dynamic
object,
Apparently this is now a void function.
Mark it as such.

https://codereview.chromium.org/902783008/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3629: streamHelper(null,
helperCallback, this, null);
Why do we need to call the streamHelper when we are paused?

[sigurdm, 2015-02-10 13:33:44]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[sigurdm, 2015-02-10 13:35:52]

https://codereview.chromium.org/902783008/diff/20001/pkg/compiler/lib/src/js/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/902783008/diff/20001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:191: /// Sepcific to async* methods.
On 2015/02/10 13:27:50, floitsch wrote:
> Specific

Done.

https://codereview.chromium.org/902783008/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/902783008/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3553: streamHelper(dynamic
object,
On 2015/02/10 13:27:50, floitsch wrote:
> Apparently this is now a void function.
> Mark it as such.

Done.

https://codereview.chromium.org/902783008/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3629: streamHelper(null,
helperCallback, this, null);
On 2015/02/10 13:27:50, floitsch wrote:
> Why do we need to call the streamHelper when we are paused?

Yes, this is wrong - we should not do anything onPause.

Thanks

[floitsch, 2015-02-10 14:11:37]

Still LGTM.

[sigurdm, 2015-02-10 14:20:17]

Committed patchset #3 (id:60001) manually as 43646 (presubmit successful).