Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 902273002: Don't propose fixes to update SDK sources. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't propose fixes to update SDK sources. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 10 months ago (2015-02-06 22:11:32 UTC) #1
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-06 22:17:47 UTC) #2
jwren
On 2015/02/06 22:17:47, Brian Wilkerson wrote: > LGTM The email mentions that code in imported ...
5 years, 10 months ago (2015-02-06 22:20:08 UTC) #3
scheglov
5 years, 10 months ago (2015-02-06 22:21:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698