Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 902073002: Migrate to cli_util for SDK detection logic (Closed)

Created:
5 years, 10 months ago by pquitslund
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/code-transformers.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -40 lines) Patch
M lib/src/dart_sdk.dart View 1 2 chunks +5 lines, -40 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
5 years, 10 months ago (2015-02-05 23:21:43 UTC) #2
jakemac
lgtm https://codereview.chromium.org/902073002/diff/1/lib/src/dart_sdk.dart File lib/src/dart_sdk.dart (right): https://codereview.chromium.org/902073002/diff/1/lib/src/dart_sdk.dart#newcode8 lib/src/dart_sdk.dart:8: import 'dart:io' show Directory, File, Link, Platform, Process; ...
5 years, 10 months ago (2015-02-05 23:22:22 UTC) #3
pquitslund
Nits addressed. Thanks! https://codereview.chromium.org/902073002/diff/1/lib/src/dart_sdk.dart File lib/src/dart_sdk.dart (right): https://codereview.chromium.org/902073002/diff/1/lib/src/dart_sdk.dart#newcode8 lib/src/dart_sdk.dart:8: import 'dart:io' show Directory, File, Link, ...
5 years, 10 months ago (2015-02-05 23:36:48 UTC) #5
jakemac
nice lgtm
5 years, 10 months ago (2015-02-05 23:40:10 UTC) #6
pquitslund
5 years, 10 months ago (2015-02-06 16:54:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a6da8f53db568f4cbbe9b589443bde3b69c98705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698