dart2js: add constructor for directly instatiated mixin classes in the new emitter.

dart2js: add constructor for directly instatiated mixin classes in the new emitter.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43553

[zarah, 2015-02-06 10:59:56]

zarah@google.com changed reviewers:
+ floitsch@google.com, herhut@google.com

[floitsch, 2015-02-06 12:41:20]

LGTM.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:468: "Mixins have
a reference to their mixin class followed by a constructor" +
You don't need the "+" if two string literals are next to each other.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:468: "Mixins have
a reference to their mixin class followed by a constructor" +
"Mixins have a reference to their mixin class at the place of the usual
constructor. If they are instantiated the constructor follows the reference."

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:469: "function in
the case they have been directly instatiated";
"instantiated.";

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:810: // The mixin
application has been directly instatiated and hence it has a
// Descriptor[4] contains the constructor if the mixin application is directly
instantiated.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:811: //
construtor function.
constructor

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:835: function
compileMixinConstructor(name, prototype, descriptor) {
Doesn't do the constructor anymore.

copyMixedInMethods?
fillPrototypeWithMixedIn ?

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:835: function
compileMixinConstructor(name, prototype, descriptor) {
name seems to be unused. -> remove.

Maybe pass in mixinName and mixinHolderIndex directly. This way the
$mixinFormatDescription is only needed in one location.

[zarah, 2015-02-06 14:26:51]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[zarah, 2015-02-06 14:27:09]

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:468: "Mixins have
a reference to their mixin class followed by a constructor" +
On 2015/02/06 12:41:19, floitsch wrote:
> "Mixins have a reference to their mixin class at the place of the usual
> constructor. If they are instantiated the constructor follows the reference."

Done.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:468: "Mixins have
a reference to their mixin class followed by a constructor" +
On 2015/02/06 12:41:19, floitsch wrote:
> "Mixins have a reference to their mixin class at the place of the usual
> constructor. If they are instantiated the constructor follows the reference."

Done.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:469: "function in
the case they have been directly instatiated";
On 2015/02/06 12:41:19, floitsch wrote:
> "instantiated.";

Acknowledged.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:810: // The mixin
application has been directly instatiated and hence it has a
On 2015/02/06 12:41:20, floitsch wrote:
> // Descriptor[4] contains the constructor if the mixin application is directly
> instantiated.

Done.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:811: //
construtor function.
On 2015/02/06 12:41:19, floitsch wrote:
> constructor

Acknowledged.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:835: function
compileMixinConstructor(name, prototype, descriptor) {
On 2015/02/06 12:41:19, floitsch wrote:
> name seems to be unused. -> remove.
> 
> Maybe pass in mixinName and mixinHolderIndex directly. This way the
> $mixinFormatDescription is only needed in one location.

Done.

https://codereview.chromium.org/900423003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:835: function
compileMixinConstructor(name, prototype, descriptor) {
On 2015/02/06 12:41:19, floitsch wrote:
> Doesn't do the constructor anymore.
> 
> copyMixedInMethods?
> fillPrototypeWithMixedIn ?

Done.

[zarah, 2015-02-06 14:27:55]

Committed patchset #2 (id:20001) manually as 43553 (presubmit successful).