Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 899753004: Send notificatinos after no-op changes. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Send notificatinos after no-op changes. This should solve the problem when client remove some part of the code, so removes also error markers for it, and then quickly restores it, so for the server it looks as an empty/no-op change. But information is lost, and the server should resend it to the client. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43521

Patch Set 1 #

Total comments: 2

Patch Set 2 : Schedule source analysis only if a change was made #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -77 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +38 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +70 lines, -52 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 5 chunks +54 lines, -20 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
5 years, 10 months ago (2015-02-05 19:08:20 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/899753004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/899753004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1883 pkg/analyzer/lib/src/generated/engine.dart:1883: _workManager.add(source, SourcePriority.UNKNOWN); If the state was INVALID (or ...
5 years, 10 months ago (2015-02-05 20:07:59 UTC) #2
scheglov
https://codereview.chromium.org/899753004/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/899753004/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1883 pkg/analyzer/lib/src/generated/engine.dart:1883: _workManager.add(source, SourcePriority.UNKNOWN); On 2015/02/05 20:07:59, Brian Wilkerson wrote: > ...
5 years, 10 months ago (2015-02-05 20:42:03 UTC) #4
scheglov
5 years, 10 months ago (2015-02-05 20:42:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698