- Return exit code 253 in case of API errors during loading. This

- Return exit code 253 in case of API errors during loading. This
  will trigger for example when loading outdated snapshots.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43505

[Ivan Posva, 2015-02-05 13:45:47]

iposva@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2015-02-05 14:00:42]

lgtm

https://codereview.chromium.org/899523005/diff/1/runtime/tests/vm/dart/snapsh...
File runtime/tests/vm/dart/snapshot_version_test.dart (right):

https://codereview.chromium.org/899523005/diff/1/runtime/tests/vm/dart/snapsh...
runtime/tests/vm/dart/snapshot_version_test.dart:10:
[Platform.script.resolve('./bad_snapshot').toFilePath()]);
do you need ./ here? (not sure how that works on windows)

https://codereview.chromium.org/899523005/diff/1/runtime/tests/vm/dart/snapsh...
runtime/tests/vm/dart/snapshot_version_test.dart:11: print("=== stdout ===\n
${result.stdout}");
remove the prints?

https://codereview.chromium.org/899523005/diff/1/tools/testing/dart/test_runn...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/899523005/diff/1/tools/testing/dart/test_runn...
tools/testing/dart/test_runner.dart:948: // as an invalid snapshot file.
dart2js exits with code 253 in case of a compiler failure.
The dart binary ....
Both are considered crashes.

[Ivan Posva, 2015-02-05 14:25:33]

New patchsets have been uploaded after l-g-t-m from ricow@google.com

[Ivan Posva, 2015-02-05 14:26:24]

https://codereview.chromium.org/899523005/diff/1/runtime/tests/vm/dart/snapsh...
File runtime/tests/vm/dart/snapshot_version_test.dart (right):

https://codereview.chromium.org/899523005/diff/1/runtime/tests/vm/dart/snapsh...
runtime/tests/vm/dart/snapshot_version_test.dart:10:
[Platform.script.resolve('./bad_snapshot').toFilePath()]);
On 2015/02/05 14:00:42, ricow1 wrote:
> do you need ./ here? (not sure how that works on windows)

As far as I remember / is the right thing to use for URI resolution on Windows.
I prefer the ./ to make it absolutely clear that this file is in the current
directory.

https://codereview.chromium.org/899523005/diff/1/runtime/tests/vm/dart/snapsh...
runtime/tests/vm/dart/snapshot_version_test.dart:11: print("=== stdout ===\n
${result.stdout}");
On 2015/02/05 14:00:42, ricow1 wrote:
> remove the prints?

The prints make it much easier to diagnose in case of failure.

https://codereview.chromium.org/899523005/diff/1/tools/testing/dart/test_runn...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/899523005/diff/1/tools/testing/dart/test_runn...
tools/testing/dart/test_runner.dart:948: // as an invalid snapshot file.
On 2015/02/05 14:00:42, ricow1 wrote:
> dart2js exits with code 253 in case of a compiler failure.
> The dart binary ....
> Both are considered crashes.

Done.

[Ivan Posva, 2015-02-05 14:30:33]

Committed patchset #2 (id:20001) manually as r43505 (presubmit successful).