Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899513003: Improve error reporting on status page (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve error reporting on status page R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43374

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/ast_writer.dart View 3 chunks +20 lines, -1 line 3 comments Download

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
5 years, 10 months ago (2015-02-02 23:03:58 UTC) #2
Paul Berry
lgtm. Your call on the nit below. https://codereview.chromium.org/899513003/diff/1/pkg/analysis_server/lib/src/status/ast_writer.dart File pkg/analysis_server/lib/src/status/ast_writer.dart (right): https://codereview.chromium.org/899513003/diff/1/pkg/analysis_server/lib/src/status/ast_writer.dart#newcode194 pkg/analysis_server/lib/src/status/ast_writer.dart:194: buffer.write(HTML_ESCAPE.convert(value.runtimeType.toString())); Nit: ...
5 years, 10 months ago (2015-02-02 23:08:59 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/899513003/diff/1/pkg/analysis_server/lib/src/status/ast_writer.dart File pkg/analysis_server/lib/src/status/ast_writer.dart (right): https://codereview.chromium.org/899513003/diff/1/pkg/analysis_server/lib/src/status/ast_writer.dart#newcode194 pkg/analysis_server/lib/src/status/ast_writer.dart:194: buffer.write(HTML_ESCAPE.convert(value.runtimeType.toString())); Why? The value of 'value' is known to ...
5 years, 10 months ago (2015-02-02 23:25:03 UTC) #4
Paul Berry
https://codereview.chromium.org/899513003/diff/1/pkg/analysis_server/lib/src/status/ast_writer.dart File pkg/analysis_server/lib/src/status/ast_writer.dart (right): https://codereview.chromium.org/899513003/diff/1/pkg/analysis_server/lib/src/status/ast_writer.dart#newcode194 pkg/analysis_server/lib/src/status/ast_writer.dart:194: buffer.write(HTML_ESCAPE.convert(value.runtimeType.toString())); On 2015/02/02 23:25:03, Brian Wilkerson wrote: > Why? ...
5 years, 10 months ago (2015-02-02 23:32:27 UTC) #5
Brian Wilkerson
5 years, 10 months ago (2015-02-02 23:34:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698