Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 899093003: Update the README to match the current API. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/json_rpc_2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -71 lines) Patch
M README.md View 1 1 chunk +100 lines, -71 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 10 months ago (2015-02-05 00:26:15 UTC) #1
Bob Nystrom
https://codereview.chromium.org/899093003/diff/1/README.md File README.md (right): https://codereview.chromium.org/899093003/diff/1/README.md#newcode13 README.md:13: WebSocket.connect('ws://localhost:4321').then((socket) { Would it be premature to use await ...
5 years, 10 months ago (2015-02-05 00:32:25 UTC) #2
nweiz
Code review changes
5 years, 10 months ago (2015-02-05 01:01:55 UTC) #3
nweiz
https://codereview.chromium.org/899093003/diff/1/README.md File README.md (right): https://codereview.chromium.org/899093003/diff/1/README.md#newcode13 README.md:13: WebSocket.connect('ws://localhost:4321').then((socket) { On 2015/02/05 00:32:24, Bob Nystrom wrote: > ...
5 years, 10 months ago (2015-02-05 01:02:48 UTC) #4
Bob Nystrom
lgtm
5 years, 10 months ago (2015-02-05 01:09:48 UTC) #5
nweiz
5 years, 10 months ago (2015-02-06 00:26:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8bf9eca481e48aad17271105d4f933d85f3b5955 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698