Issue 898703004: Fix async_test problems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898703004: Fix async_test problems. (Closed)

Created:
5 years, 10 months ago by Johnni Winther

Modified:
5 years, 10 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix async_test problems. + disallow async modifier on setters. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=43465

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -8 lines)			Patch
M	pkg/compiler/lib/src/resolution/members.dart	View	1 chunk	+12 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/warnings.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/language/async_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

sigurdm

lgtm. I would add to the CL description, that it also fixes a bug, disallowing ...

5 years, 10 months ago (2015-02-04 12:22:43 UTC) #3

Johnni Winther

5 years, 10 months ago (2015-02-04 12:42:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43465 (presubmit successful).