Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 898453009: Add missing call to VerifiedMemory::Accept when initializing Smi field. (Closed)

Created:
5 years, 10 months ago by koda
Modified:
5 years, 10 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add missing call to VerifiedMemory::Accept when initializing Smi field. BUG=dart:22224 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/raw_object.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 10 months ago (2015-02-05 15:10:09 UTC) #1
koda
Note that this only fixes one of the failures reported in bug 22224, which is ...
5 years, 10 months ago (2015-02-05 18:07:47 UTC) #3
siva
lgtm
5 years, 10 months ago (2015-02-05 18:18:44 UTC) #4
koda
5 years, 10 months ago (2015-02-06 00:02:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698