Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 898303002: Support instance methods in analyzer2dart. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Support instance methods in analyzer2dart. BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43555

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -15 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 8 chunks +24 lines, -11 lines 1 comment Download
M pkg/analyzer2dart/lib/src/dart_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/lib/src/element_converter.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/lib/src/modely.dart View 5 chunks +41 lines, -3 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +12 lines, -0 lines 1 comment Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 chunk +26 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 10 months ago (2015-02-06 12:33:56 UTC) #2
Paul Berry
lgtm
5 years, 10 months ago (2015-02-06 14:51:53 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 43555 (presubmit successful).
5 years, 10 months ago (2015-02-06 14:59:49 UTC) #4
sigurdm
5 years, 10 months ago (2015-02-06 15:04:47 UTC) #5
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/898303002/diff/1/pkg/analyzer2dart/lib/src/cp...
File pkg/analyzer2dart/lib/src/cps_generator.dart (right):

https://codereview.chromium.org/898303002/diff/1/pkg/analyzer2dart/lib/src/cp...
pkg/analyzer2dart/lib/src/cps_generator.dart:105: // Call to allow for `body ==
null` in case of synthesized constructors.
Call `build` ...

https://codereview.chromium.org/898303002/diff/1/pkg/analyzer2dart/test/end2e...
File pkg/analyzer2dart/test/end2end_data.dart (right):

https://codereview.chromium.org/898303002/diff/1/pkg/analyzer2dart/test/end2e...
pkg/analyzer2dart/test/end2end_data.dart:839: return new C().foo();
You could add arguments to make the test stronger.

https://codereview.chromium.org/898303002/diff/1/pkg/analyzer2dart/test/sexpr...
File pkg/analyzer2dart/test/sexpr_data.dart (right):

https://codereview.chromium.org/898303002/diff/1/pkg/analyzer2dart/test/sexpr...
pkg/analyzer2dart/test/sexpr_data.dart:1417: return new C().foo();
You could add arguments to make the test stronger

Powered by Google App Engine
This is Rietveld 408576698