Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 898113002: Add sharedfrontend package (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add sharedfrontend package - initial element model includes Element, LibraryElement and ClassElement - AccessSemantics moved to sharedfrontend to be utilized from both analyzer2dart and dart2js. BUG= R=brianwilkerson@google.com, paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43635 Reverted: https://code.google.com/p/dart/source/detail?r=43637

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Update status. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -290 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 2 1 chunk +2 lines, -0 lines 1 comment Download
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer2dart/lib/src/identifier_semantics.dart View 8 chunks +142 lines, -266 lines 0 comments Download
M pkg/analyzer2dart/lib/src/semantic_visitor.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer2dart/lib/src/tree_shaker.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer2dart/test/identifier_semantics_test.dart View 8 chunks +18 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkgbuild.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A pkg/sharedfrontend/lib/elements.dart View 1 1 chunk +37 lines, -0 lines 0 comments Download
A pkg/sharedfrontend/lib/src/access_semantics.dart View 1 chunk +264 lines, -0 lines 0 comments Download
A pkg/sharedfrontend/pubspec.yaml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Johnni Winther
5 years, 10 months ago (2015-02-05 16:02:48 UTC) #2
Brian Wilkerson
In order to add this package we need to add a dependency on 'sharedfrontend' to ...
5 years, 10 months ago (2015-02-05 17:09:37 UTC) #3
Paul Berry
lgtm
5 years, 10 months ago (2015-02-05 17:30:44 UTC) #4
Johnni Winther
Updated the pubspec.yaml to contain a path reference. I guess publishing sharedfrontend can be postponed ...
5 years, 10 months ago (2015-02-10 10:13:03 UTC) #6
Johnni Winther
Committed patchset #2 (id:20001) manually as 43635 (presubmit successful).
5 years, 10 months ago (2015-02-10 10:46:48 UTC) #7
Johnni Winther
PTAL at the last patch.
5 years, 10 months ago (2015-02-10 15:12:47 UTC) #8
Brian Wilkerson
5 years, 10 months ago (2015-02-10 15:52:58 UTC) #9
I still don't like the architecture that we're heading toward. I'd like to
discuss this CL in our meeting tomorrow. In particular, I'd like to understand
why dart2js can't just depend on analyzer directly instead of relying on an
intermediate package.

https://codereview.chromium.org/898113002/diff/40001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/898113002/diff/40001/pkg/analyzer/pubspec.yam...
pkg/analyzer/pubspec.yaml:13: path: ../../pkg/sharedfrontend/
Unless I'm misunderstanding something, we can publish this to pub.dartlang.org
(which means we wouldn't be able to publish a new version of analyzer if we
needed to). This only works when downloading the analyzer package as part of the
SVN repository, which many users don't do.

Powered by Google App Engine
This is Rietveld 408576698