Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 897833002: fix exception and improve keyword completion (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix exception and improve keyword completion BUG=dartbug.com/22231 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43466

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -46 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 3 chunks +75 lines, -43 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 8 chunks +145 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years, 10 months ago (2015-02-04 03:47:50 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-04 04:51:27 UTC) #3
danrubel
5 years, 10 months ago (2015-02-04 13:18:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43466 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698