Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897703002: Make _FileSystemWatcher.watch private. (Closed)

Created:
5 years, 10 months ago by rmacnak
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make _FileSystemWatcher.watch private. It doesn't verify the path is a string before running native code, so when invoked via mirrors it will hit an uncatchable API error instead of a Dart exception. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43487

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/bin/file_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/io_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_system_entity.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 10 months ago (2015-02-03 20:34:37 UTC) #2
siva
lgtm
5 years, 10 months ago (2015-02-04 20:56:04 UTC) #3
rmacnak
5 years, 10 months ago (2015-02-04 21:39:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698