Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 897673003: Implement new return type checking rules in analyzer. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement new return type checking rules in analyzer. This updates the analyzer to reflect the new static type checking rules for return types added in r43420. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43427

Patch Set 1 #

Patch Set 2 : Reformat and sort class members. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 3 chunks +39 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 7 chunks +98 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-03 21:09:26 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-03 21:12:50 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-03 21:25:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698