Adds a repeatable --url_mapping flag to dartanalyzer

Adds a repeatable --url_mapping flag to dartanalyzer

If a Dart file does an import that is 'strange', this flag
allows the imported URI to be understood by the analyzer
so long as an explicit mapping of the URI to an absolute
path to a .dart file is supplied with this flag.

For example, a custom embedding of the Dart VM may refer
to non-SDK libraries through its own URI scheme, e.g.

import 'strange:things';

With the flag and Uri resolver added in this CL, the
analyzer can find the Dart source for 'strange:things':

dartanalyzer ... --url_mapping 'strange:things,/path/to/strange/things.dart'

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43788

[zra, 2015-02-10 00:35:06]

zra@google.com changed reviewers:
+ brianwilkerson@google.com

[zra, 2015-02-10 00:35:07]

Hi Brian,

This is what I have in mind. I tried this out on my use-case and it worked as
expected. I'm having trouble finding a good place to add a test for this
feature, though. Do you have a recommendation about that?

Thanks!

[zra, 2015-02-11 16:48:30]

Friendly ping.

[zra, 2015-02-12 21:05:00]

zra@google.com changed reviewers:
+ danrubel@google.com

[zra, 2015-02-12 21:05:01]

+danrubel

Seth suggested adding Dan in case he has more cycles to review. I'll send
context over email.

[Brian Wilkerson, 2015-02-13 23:56:13]

LGTM once comments are addressed

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/options.dart
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/options.dar...
pkg/analyzer/lib/options.dart:209: 'url_mapping',
I know it's inconsistent with the python script, but all of analyzer's other
options use hyphen as a separator rather than underscore.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/options.dar...
pkg/analyzer/lib/options.dart:276: for (var mapping in results['url_mapping']) {
Everything in analyzer is fully type annotated.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/source.dart:170: class CustomUriResolver extends
UriResolver {
It would be good to have some tests for this class.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/source.dart:181: if (!fileUri.isAbsolute) return
null;
I don't have source available at the moment, but in Java, the method
isAbsolute() means "has a scheme". I believe Uri.file always provides a "file"
scheme, so I'm guessing this condition isn't doing what you think it is. (But
I'm not that familiar with Dart's Uri class yet, so it might work differently.)

[zra, 2015-02-14 00:59:35]

New patchsets have been uploaded after l-g-t-m from brianwilkerson@google.com

[zra, 2015-02-14 01:01:56]

Thanks!

Tests added for the new resolver class. ptal.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/options.dart
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/options.dar...
pkg/analyzer/lib/options.dart:209: 'url_mapping',
On 2015/02/13 23:56:13, Brian Wilkerson wrote:
> I know it's inconsistent with the python script, but all of analyzer's other
> options use hyphen as a separator rather than underscore.

Done.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/options.dar...
pkg/analyzer/lib/options.dart:276: for (var mapping in results['url_mapping']) {
On 2015/02/13 23:56:13, Brian Wilkerson wrote:
> Everything in analyzer is fully type annotated.

Done.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/source.dart:170: class CustomUriResolver extends
UriResolver {
On 2015/02/13 23:56:13, Brian Wilkerson wrote:
> It would be good to have some tests for this class.

Done.

https://codereview.chromium.org/897593005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/source.dart:181: if (!fileUri.isAbsolute) return
null;
On 2015/02/13 23:56:13, Brian Wilkerson wrote:
> I don't have source available at the moment, but in Java, the method
> isAbsolute() means "has a scheme". I believe Uri.file always provides a "file"
> scheme, so I'm guessing this condition isn't doing what you think it is. (But
> I'm not that familiar with Dart's Uri class yet, so it might work
differently.)

The docs for Uri.file say "If the path starts with a path separator an absolute
URI is created. Otherwise a relative URI is created." It looks like this meaning
of "absolute" is consistent other places in the docs.

[Brian Wilkerson, 2015-02-14 01:13:13]

LGTM. Thanks for implementing this!

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/options...
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/options...
pkg/analyzer/lib/options.dart:277: var splitMapping = mapping.split(',');
missing type

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/source.dart:177: var mapping =
_urlMappings[uri.toString()];
missing type

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/source.dart:180: var fileUri = new
Uri.file(mapping);
missing type

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/source.dart:183: var javaFile = new
JavaFile.fromUri(fileUri);
missing type

[zra, 2015-02-14 06:40:42]

New patchsets have been uploaded after l-g-t-m from brianwilkerson@google.com

[zra, 2015-02-14 07:18:22]

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/options...
File pkg/analyzer/lib/options.dart (right):

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/options...
pkg/analyzer/lib/options.dart:277: var splitMapping = mapping.split(',');
On 2015/02/14 01:13:13, Brian Wilkerson wrote:
> missing type

Done.

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/source.dart:177: var mapping =
_urlMappings[uri.toString()];
On 2015/02/14 01:13:13, Brian Wilkerson wrote:
> missing type

Done.

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/source.dart:180: var fileUri = new
Uri.file(mapping);
On 2015/02/14 01:13:13, Brian Wilkerson wrote:
> missing type

Done.

https://codereview.chromium.org/897593005/diff/40001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/source.dart:183: var javaFile = new
JavaFile.fromUri(fileUri);
On 2015/02/14 01:13:13, Brian Wilkerson wrote:
> missing type

Done.

[zra, 2015-02-14 07:19:22]

Committed patchset #4 (id:60001) manually as r43788 (presubmit successful).