Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 89713002: clarify that users of Polymer mixin have to call polymerCreated (Closed)

Created:
7 years ago by sethladd
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

clarify that users of Polymer mixin have to call polymerCreated BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30800

Patch Set 1 #

Patch Set 2 : much better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/polymer/lib/src/instance.dart View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sethladd
I think this is correct. It's not documented and it was a surprise to me ...
7 years ago (2013-11-26 23:51:33 UTC) #1
Jennifer Messerly
lgtm
7 years ago (2013-11-27 00:36:17 UTC) #2
sethladd
7 years ago (2013-12-02 18:00:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698