Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896623002: Don't use firstWhere as it throws an error if there is no such element (Closed)

Created:
5 years, 10 months ago by jwren
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use firstWhere as it throws an error if there is no such element R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43372

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/generated/source.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
jwren
5 years, 10 months ago (2015-02-02 23:13:07 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (left): https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart#oldcode609 pkg/analyzer/lib/src/generated/source.dart:609: _resolvers.firstWhere((r) => r is PackageMapUriResolver, orElse: null); Nit: ...
5 years, 10 months ago (2015-02-02 23:15:25 UTC) #3
pquitslund
Paul beat me to addressing the salient bit. Otherwise a nit: https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (right): ...
5 years, 10 months ago (2015-02-02 23:19:12 UTC) #4
pquitslund
https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (left): https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart#oldcode609 pkg/analyzer/lib/src/generated/source.dart:609: _resolvers.firstWhere((r) => r is PackageMapUriResolver, orElse: null); On 2015/02/02 ...
5 years, 10 months ago (2015-02-02 23:19:39 UTC) #5
jwren
On 2015/02/02 23:19:39, pquitslund wrote: > https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart > File pkg/analyzer/lib/src/generated/source.dart (left): > > https://codereview.chromium.org/896623002/diff/1/pkg/analyzer/lib/src/generated/source.dart#oldcode609 > ...
5 years, 10 months ago (2015-02-02 23:26:42 UTC) #6
jwren
5 years, 10 months ago (2015-02-02 23:27:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698