Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 896293003: Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generic… (Closed)

Created:
5 years, 10 months ago by Jacob
Modified:
5 years, 10 months ago
Reviewers:
terry, Alan Knight
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup method signatures that were incorrect due to a lack of understanding about how Dart generics work. BUG= R=alanknight@google.com, terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=43562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/shared_html.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jacob
Without this fix querySelectorAll acts more like it is returning List<dynamic> than List<Element> which causes ...
5 years, 10 months ago (2015-02-06 02:58:29 UTC) #2
terry
On 2015/02/06 02:58:29, Jacob wrote: > Without this fix querySelectorAll acts more like it is ...
5 years, 10 months ago (2015-02-06 16:15:40 UTC) #3
Jacob
On 2015/02/06 16:15:40, terry wrote: > On 2015/02/06 02:58:29, Jacob wrote: > > Without this ...
5 years, 10 months ago (2015-02-06 16:20:59 UTC) #4
terry
lgtm
5 years, 10 months ago (2015-02-06 17:14:50 UTC) #5
Alan Knight
lgtm
5 years, 10 months ago (2015-02-06 18:00:49 UTC) #6
Jacob
5 years, 10 months ago (2015-02-06 19:16:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698