Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 895943002: Support root-level json rpc requests in the vm service. (Closed)

Created:
5 years, 10 months ago by turnidge
Modified:
5 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support root-level json rpc requests in the vm service. Add getVM and getIsolate rpcs. Add support for Code objects to getObject. Begin using getVM, getIsolate, and getObject in the Observatory. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43423

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -4 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 6 chunks +22 lines, -2 lines 0 comments Download
M runtime/vm/service.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 8 chunks +139 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 10 months ago (2015-02-03 18:50:36 UTC) #2
Cutch
lgtm
5 years, 10 months ago (2015-02-03 18:52:43 UTC) #3
turnidge
5 years, 10 months ago (2015-02-03 20:31:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698