Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895813006: dart2js: store typeVariableReader stubs in the model. (Closed)

Created:
5 years, 10 months ago by zarah
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: store typeVariableReader stubs in the model. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43677

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -324 lines) Patch
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 4 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 4 chunks +4 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 7 chunks +10 lines, -5 lines 0 comments Download
A + pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 2 chunks +46 lines, -2 lines 0 comments Download
D pkg/compiler/lib/src/js_emitter/type_test_generator.dart View 1 1 chunk +0 lines, -267 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zarah
https://codereview.chromium.org/895813006/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right): https://codereview.chromium.org/895813006/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart#newcode197 pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:197: stubs.add( This method is copied from class_emitter. This line ...
5 years, 10 months ago (2015-02-10 12:50:30 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/895813006/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right): https://codereview.chromium.org/895813006/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart#newcode190 pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:190: List<StubMethod> generateTypeVariableReaderStubs(ClassElement classElement) { An alternative location would ...
5 years, 10 months ago (2015-02-10 13:19:37 UTC) #3
zarah
https://codereview.chromium.org/895813006/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right): https://codereview.chromium.org/895813006/diff/1/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart#newcode190 pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:190: List<StubMethod> generateTypeVariableReaderStubs(ClassElement classElement) { On 2015/02/10 13:19:36, floitsch wrote: ...
5 years, 10 months ago (2015-02-10 13:34:39 UTC) #5
floitsch
Still LGTM.
5 years, 10 months ago (2015-02-10 14:12:58 UTC) #6
zarah
5 years, 10 months ago (2015-02-11 09:49:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698