Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 895673005: Add static type checking of "yield*" statements to analyzer. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add static type checking of "yield*" statements to analyzer. This does not include the new static typing rules that were introduced in revision 43420. I will address those in a later CL. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43424

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -12 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +156 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M tests/language/async_await_syntax_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-03 19:49:59 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-03 20:18:49 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-03 20:32:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698