Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 895113002: Add static type checking of "yield" statements to analyzer. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add static type checking of "yield" statements to analyzer. Also fix inference of the return type of generator function expressions. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +34 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 7 chunks +56 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 4 chunks +40 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +112 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 5 chunks +40 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 10 months ago (2015-02-03 18:28:51 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-03 18:39:16 UTC) #3
Paul Berry
5 years, 10 months ago (2015-02-03 18:51:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698