Issue 895063002: Add member type to model.

Issue 895063002: Add member type to model. (Closed)

Created:
5 years, 10 months ago by herhut

Modified:
5 years, 10 months ago

Reviewers:
karlklose, floitsch, zarah

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add member type to model. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43400

Patch Set 2 : Rebase #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -14 lines)			Patch
M	pkg/compiler/lib/src/js_emitter/model.dart	View	1	4 chunks	+6 lines, -5 lines	1 comment	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder.dart	View	1	2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

LGTM. https://codereview.chromium.org/895063002/diff/1/pkg/compiler/lib/src/js_emitter/program_builder.dart File pkg/compiler/lib/src/js_emitter/program_builder.dart (right): https://codereview.chromium.org/895063002/diff/1/pkg/compiler/lib/src/js_emitter/program_builder.dart#newcode469 pkg/compiler/lib/src/js_emitter/program_builder.dart:469: // reflected. probably for reflection.

5 years, 10 months ago (2015-02-03 14:14:15 UTC) #4

herhut

Committed patchset #2 (id:20001) manually as 43400 (presubmit successful).

5 years, 10 months ago (2015-02-03 14:29:36 UTC) #5

karlklose

5 years, 10 months ago (2015-02-03 14:41:16 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/895063002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://codereview.chromium.org/895063002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/model.dart:374: String callName, DartType type,
I think 'type' should be a 'FunctionType'.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages