Issue 89493002: Fix some static warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 89493002: Fix some static warnings. (Closed)

Created:
7 years ago by Bob Nystrom

Modified:
7 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some static warnings. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=30682

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/dart.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/safe_http_server.dart	View	2 chunks	+3 lines, -1 line	2 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/git.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/hosted.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm + one request https://codereview.chromium.org/89493002/diff/1/sdk/lib/_internal/pub/lib/src/safe_http_server.dart File sdk/lib/_internal/pub/lib/src/safe_http_server.dart (right): https://codereview.chromium.org/89493002/diff/1/sdk/lib/_internal/pub/lib/src/safe_http_server.dart#newcode169 sdk/lib/_internal/pub/lib/src/safe_http_server.dart:169: } Can you fix this ...

7 years ago (2013-11-26 22:53:29 UTC) #2

Bob Nystrom

https://codereview.chromium.org/89493002/diff/1/sdk/lib/_internal/pub/lib/src/safe_http_server.dart File sdk/lib/_internal/pub/lib/src/safe_http_server.dart (right): https://codereview.chromium.org/89493002/diff/1/sdk/lib/_internal/pub/lib/src/safe_http_server.dart#newcode169 sdk/lib/_internal/pub/lib/src/safe_http_server.dart:169: } On 2013/11/26 22:53:29, nweiz wrote: > Can you ...

7 years ago (2013-11-26 22:59:05 UTC) #3

Bob Nystrom

7 years ago (2013-11-26 22:59:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r30682 (presubmit successful).

Expand Messages | Collapse Messages