Support for inspecting index.

Support for inspecting index.


Page http://127.0.0.1:2040/index/element-by-name?name=sendAnalysisNotificationHighlights
shows all relations with elements named 'sendAnalysisNotificationHighlights'.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43377

[Brian Wilkerson, 2015-02-02 23:33:59]

LGTM

[Paul Berry, 2015-02-02 23:45:48]

lgtm

https://codereview.chromium.org/894853004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/get_handler.dart (right):

https://codereview.chromium.org/894853004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/get_handler.dart:731: if (index is LocalIndex) {
It would be nice to have an "else" block that generated an error message using
_returnFailure, so that in the unlikely event that index isn't a LocalIndex,
we'll get pointed in the right direction for debugging, rather than just get no
response at all.

[scheglov, 2015-02-03 03:04:49]

https://codereview.chromium.org/894853004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/get_handler.dart (right):

https://codereview.chromium.org/894853004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/get_handler.dart:731: if (index is LocalIndex) {
On 2015/02/02 23:45:47, Paul Berry wrote:
> It would be nice to have an "else" block that generated an error message using
> _returnFailure, so that in the unlikely event that index isn't a LocalIndex,
> we'll get pointed in the right direction for debugging, rather than just get
no
> response at all.

Done.

[scheglov, 2015-02-03 03:11:18]

Committed patchset #1 (id:1) manually as 43377 (presubmit successful).